-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm user api v2 endpoint #495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] master from spree:master
[pull] master from spree:master
chhlga
approved these changes
May 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pmilewski
force-pushed
the
confirm-user-api-v2-endpoint
branch
4 times, most recently
from
May 29, 2020 13:53
3de5b1e
to
51493c6
Compare
kgorazd
approved these changes
May 29, 2020
app/controllers/spree/api/v2/storefront/confirmations_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/spree/api/v2/storefront/confirmations_controller.rb
Outdated
Show resolved
Hide resolved
pmilewski
force-pushed
the
confirm-user-api-v2-endpoint
branch
from
June 1, 2020 08:56
924d1da
to
47648ab
Compare
damianlegawiec
approved these changes
Jun 1, 2020
pmilewski
force-pushed
the
confirm-user-api-v2-endpoint
branch
from
June 1, 2020 09:40
47648ab
to
647085a
Compare
tniezg
reviewed
Jun 1, 2020
app/controllers/spree/api/v2/storefront/account_confirmations_controller.rb
Outdated
Show resolved
Hide resolved
pmilewski
force-pushed
the
confirm-user-api-v2-endpoint
branch
2 times, most recently
from
June 1, 2020 11:59
a38689e
to
2e5ea1b
Compare
pmilewski
commented
Jun 1, 2020
spec/requests/spree/api/v2/storefront/account_confirmation_spec.rb
Outdated
Show resolved
Hide resolved
pmilewski
force-pushed
the
confirm-user-api-v2-endpoint
branch
from
June 2, 2020 08:33
9557a80
to
d519c51
Compare
damianlegawiec
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.