Add type annotations to cache_handler.py #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added typed to cache_handler.CacheHandler - Implemented cache_handler.CacheHandler as an ABC - Added temporary files pyproject.toml, requirements.lock, and requirements-dev.lock (Generated by rye, the tool I use to manage python projects. Will be removed when this PR is complete).
- Added type annotations to CacheFileHandler - Updated temporary files
also preemtively updated changelog
|
This should be ready to merge. I never ended up figuring out how to type-annotate the optional dependencies, but everything else is type annotated. |
stephanebruckert
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing type annotations in cache_handler.py
I will create separate PRs for each file I type to make the review process easier and to allow it to be merged in slowly.
Currently only the base CacheHandler class has been typed.
Temporary files generated by rye like the pyproject.toml and lockfiles(my preferred python management tool) will be removed when I finish this PR.