Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream Release v0.194.0 ,Con 22743 add aggressive scale down #671

Merged
merged 789 commits into from
Nov 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
789 commits
Select commit Hold shift + click to select a range
d3c6eaf
Fix typo in publish-release.yaml
yuxiang-zhang Mar 15, 2024
3c1a5c4
Merge pull request #7663 from eksctl-io/fix-typo
yuxiang-zhang Mar 15, 2024
419aebd
Prepare for next development iteration
eksctl-bot Mar 15, 2024
76902cd
Merge pull request #7664 from eksctl-io/main-3c1a5c4c2
yuxiang-zhang Mar 15, 2024
e1d1692
Upgrade with explicit version if release version is up-to-date
yuxiang-zhang Mar 19, 2024
febff8e
Test Bottlerocket node upgrade and verify version
yuxiang-zhang Mar 19, 2024
00c736d
Merge pull request #7666 from eksctl-io/fix-bottlerocket-upgrade
yuxiang-zhang Mar 21, 2024
5b28c17
Add release notes for v0.175.0 (#7669)
eksctl-bot Mar 22, 2024
1d18d74
Prepare for next development iteration (#7671)
eksctl-bot Mar 22, 2024
53aa373
Bump dependencies (#7668)
TiberiuGC Mar 22, 2024
78e6711
Aim for namespace uniqueness across parallel specs (#7680)
TiberiuGC Mar 22, 2024
42cab35
Include MixedInstancesPolicy LaunchTemplate for validation
yuxiang-zhang Mar 14, 2024
cfec0d9
Merge pull request #7661 from yuxiang-zhang/7644
yuxiang-zhang Mar 22, 2024
cdbbd6d
Allow GPU instance types for Windows nodes (#7681)
TiberiuGC Mar 27, 2024
025550a
Display full draft release notes in PR description (#7686)
qclaogui Mar 30, 2024
2ca7b65
Bump mkdocs version (#7696)
TiberiuGC Apr 2, 2024
f9475f8
Add support for AMIs based on AmazonLinux2023 (#7684)
TiberiuGC Apr 4, 2024
2addd3a
[EKSCTL create cluster command] Authorise self-managed nodes via `aws…
TiberiuGC Apr 4, 2024
66d1a5e
Enforce `authenticationMode:CONFIG_MAP` on Outposts (#7699)
TiberiuGC Apr 4, 2024
5b33f07
Add release notes for v0.176.0 (#7672)
eksctl-bot Apr 5, 2024
127757a
Prepare for next development iteration
eksctl-bot Apr 5, 2024
e747b99
Merge pull request #7701 from eksctl-io/main-5b33f073a
cPu1 Apr 8, 2024
3a00263
Bump dependencies
cPu1 Apr 8, 2024
33f60ef
Update build image tag
cPu1 Apr 8, 2024
d53aa6c
Merge pull request #7705 from cPu1/bump-deps
cPu1 Apr 8, 2024
0af6420
Bump dependencies
cPu1 Apr 16, 2024
ce836e8
Merge pull request #7712 from cPu1/bump-deps
cPu1 Apr 16, 2024
940b4bd
Fix arn build logic to support different aws partitions
timandy Apr 18, 2024
a6bc072
Merge pull request #7715 from timandy/main
cPu1 Apr 23, 2024
523605f
Fix reusing instanceRoleARN for nodegroups authorized with access ent…
Apr 15, 2024
e578254
Add note about deleting nodegroups
cPu1 Apr 15, 2024
c8be7d7
Add integration tests
cPu1 Apr 18, 2024
c2d8c80
Fix cluster deletion in tests
cPu1 Apr 22, 2024
752fded
Merge pull request #7707 from cPu1/accessentry-instance-role-arn
cPu1 Apr 24, 2024
00934fd
Allow nodegroup creation after a cluster subnet is deleted (#7714)
TiberiuGC Apr 24, 2024
9289bf8
Handle K8s service account lifecycle on `eksctl create/delete podiden…
TiberiuGC Apr 24, 2024
5cab628
Add support for Ubuntu Pro 22.04 based EKS images (#7711)
aciba90 Apr 24, 2024
5a63580
Disable IMDSv1 in unowned integration tests
cPu1 Apr 23, 2024
d35fa56
Merge pull request #7722 from cPu1/disable-imds-v1
cPu1 Apr 24, 2024
e80bb08
include pre-releases as full releases when drafting release notes
TiberiuGC Apr 24, 2024
2956a45
Merge pull request #7723 from TiberiuGC/improvement/include-pre-relea…
cPu1 Apr 25, 2024
c115419
Add utils command to migrate `iamidentitymappings` to EKS access entr…
punkwalker Apr 25, 2024
dfd89d8
Revert "[Release drafter] Treat RCs as full releases when drafting no…
TiberiuGC Apr 25, 2024
b17d037
Fix creating pod identities
cPu1 Apr 25, 2024
3a18083
Fix deleting pod identities
cPu1 Apr 25, 2024
c9ee358
Merge pull request #7727 from cPu1/fix-podidentity-creation
cPu1 Apr 25, 2024
119b4c4
Fix deleting clusters with a non-active status
cPu1 Apr 26, 2024
98e1228
Merge pull request #7728 from cPu1/fix-delete-cluster
cPu1 Apr 26, 2024
d648bc5
Add release notes for v0.177.0
TiberiuGC Apr 25, 2024
29a9324
update release notes for 0.177.0
TiberiuGC Apr 25, 2024
0229468
Merge pull request #7721 from eksctl-io/update-release-notes
cPu1 Apr 26, 2024
a6da234
Prepare for next development iteration
eksctl-bot Apr 26, 2024
4cc7918
Merge pull request #7730 from eksctl-io/main-02294680c
cPu1 Apr 29, 2024
e7b9846
Update aws-node from 1.12.6 to 1.18.1 (#7756)
consideRatio May 16, 2024
ec1ff7b
Fix kubeletExtraConfig support for AL2023
cPu1 May 16, 2024
bff6404
Merge pull request #7758 from cPu1/al2023-kubelet-extra-config
cPu1 May 16, 2024
c32ec3f
Add release notes for 0.178
cPu1 May 17, 2024
fa79d2e
Merge pull request #7769 from cPu1/release-notes-0.178
cPu1 May 17, 2024
446a2f0
Prepare for next development iteration
eksctl-bot May 17, 2024
6c2665a
Merge pull request #7772 from eksctl-io/main-fa79d2e0b
cPu1 May 23, 2024
04abf58
Support EKS 1.30
cPu1 May 16, 2024
5c1ddc7
Merge pull request #7781 from cPu1/eks-1.30
cPu1 May 23, 2024
18f8337
Add release notes for v0.179.0
cPu1 May 23, 2024
b8f1ac4
Merge pull request #7771 from eksctl-io/update-release-notes
cPu1 May 24, 2024
b9fb579
Prepare for next development iteration
eksctl-bot May 24, 2024
2974871
Merge pull request #7783 from eksctl-io/main-b8f1ac4d7
cPu1 May 24, 2024
5619e9f
Add option to create service account for pod identities which default…
TiberiuGC May 29, 2024
586f9d1
Update json schema (#7788)
TiberiuGC May 29, 2024
5271ed1
[Pod Identity Associations] Don't allow `--create-service-account` fl…
TiberiuGC May 29, 2024
7630270
Add release notes for v0.180.0 (#7782)
eksctl-bot May 29, 2024
ef67ded
Prepare for next development iteration (#7791)
eksctl-bot May 29, 2024
5782494
add new addon fields required for pod identity support
TiberiuGC Apr 25, 2024
1d5b861
ammend create addon command to create roles for pod identity associat…
TiberiuGC Apr 29, 2024
cc94cf1
ammend delete addon command to delete roles for pod identity associat…
TiberiuGC Apr 30, 2024
a645a6e
small tweaks
TiberiuGC Apr 30, 2024
3c535ef
Support updating podIdentityAssociations for addons
cPu1 Apr 29, 2024
4be08c8
Show addon.podIdentityAssociations in `get addon`
cPu1 Apr 29, 2024
e079911
Disallow updating podidentityassociations owned by addons
cPu1 Apr 29, 2024
1e69cf0
Show pod identities in `get addons`, use a pointer for addon.podIdent…
cPu1 May 6, 2024
961bd52
Update mocks
cPu1 May 6, 2024
07d83f1
Fix deleting the specified addon instead of all addons
cPu1 May 6, 2024
bfb0a8b
Disallow deletion of addon pod identities in `delete podidentityassoc…
cPu1 May 6, 2024
77f841d
Show ownerARN in `get podidentityassociations`
cPu1 May 6, 2024
aeac061
Fix `create cluster` when iam.podIdentityAssociations is unset
cPu1 May 6, 2024
b9eea35
Delete IAM resources when addon.podIdentityAssociations is []
cPu1 May 7, 2024
1b0c2ca
take into account that not all EKS addons will support pod IDs at launch
TiberiuGC May 9, 2024
7e32105
add validations
TiberiuGC May 9, 2024
cca112c
Migrate EKS addons to pod identity using the Addons API
cPu1 May 9, 2024
8b9c4db
add unit tests and update generated files
TiberiuGC May 12, 2024
5a58bc4
Migrate: ignore pod identity associations that already exist
cPu1 May 10, 2024
0afd1ac
add docs && tweak validation
TiberiuGC May 14, 2024
3c4d4ee
Delete old IRSA stack in `update addon`
cPu1 May 15, 2024
d5b6778
Add integration test for addon.podIdentityAssociations
cPu1 May 22, 2024
8a36b28
add integration tests for creating and deleting addons && bugfixes ar…
TiberiuGC May 27, 2024
4bb1a7d
update describe addon config command to return pod identity config
TiberiuGC May 27, 2024
c63f625
add auto-create-pod-identity-associations CLI flag
TiberiuGC May 27, 2024
80ecc7b
update unit tests
TiberiuGC May 27, 2024
befc6a9
update list of minimum IAM permissions
TiberiuGC May 28, 2024
d970920
tech debt - unskip tests from PI suite
TiberiuGC May 28, 2024
55004c1
fix addons integration test
TiberiuGC May 29, 2024
dda4a32
Allow updating addons with recommended IAM policies, disallow setting…
cPu1 May 30, 2024
5a96c5e
Add more validation
cPu1 Jun 3, 2024
6a73694
Rename fields to addonsConfig.autoApplyPodIdentityAssociations and ad…
cPu1 Jun 3, 2024
bb87f30
Update AWS SDK
cPu1 Jun 3, 2024
e64db43
use service level endpoint resolver instead of global endpoint resolv…
TiberiuGC Jun 3, 2024
b71d96e
Update link to docs
cPu1 Jun 3, 2024
c7955ae
Merge pull request #7807 from TiberiuGC/addon-podidentity
cPu1 Jun 3, 2024
f2b9816
Disallow IRSA config if addon has existing pod identity associations
cPu1 Jun 3, 2024
8a4de0a
Merge pull request #7813 from cPu1/addon-podidentity-update
cPu1 Jun 3, 2024
cd52c56
Add release notes for v0.181.0
cPu1 Jun 3, 2024
48a8e87
Merge pull request #7790 from eksctl-io/update-release-notes
cPu1 Jun 3, 2024
0c5a279
Prepare for next development iteration
eksctl-bot Jun 3, 2024
7331dc1
Merge pull request #7815 from eksctl-io/main-48a8e87de
cPu1 Jun 4, 2024
0e9dbbd
Fix formatting for notes in documentation
cPu1 Jun 4, 2024
9ad0474
apply same formatting fix for addons.md file
TiberiuGC Jun 4, 2024
5e5419f
Merge pull request #7817 from cPu1/fix-docs-formatting
cPu1 Jun 4, 2024
105b6db
G6 support
practicusai Jun 6, 2024
4ee5579
Subnets availability validation should use AZs resolved by `EC2::Desc…
TiberiuGC Jun 6, 2024
09dd74f
Update pkg/addons/assets/efa-device-plugin.yaml
practicusai Jun 6, 2024
a1f05d3
Update pkg/addons/assets/efa-device-plugin.yaml
practicusai Jun 6, 2024
7aade08
Merge branch 'main' into g6-support
practicusai Jun 6, 2024
68695db
Merge pull request #7819 from practicusai/g6-support
cPu1 Jun 6, 2024
54e9b87
Fix upgrading AL2 ARM64 nodegroups
cPu1 Jun 6, 2024
631488f
Merge pull request #7821 from cPu1/fix-al2-arm64-upgrade
cPu1 Jun 7, 2024
30b7885
fix typo for iam policy
richzw Jun 6, 2024
4dd55bf
Merge pull request #7820 from richzw/main
cPu1 Jun 7, 2024
be4a37a
update aws-node to latest version
TiberiuGC May 16, 2024
a33bfab
coredns script should exclude preview versions
TiberiuGC May 17, 2024
e7c402c
Merge pull request #7766 from eksctl-io/bugfix/update-generated-files
cPu1 Jun 7, 2024
ac497e2
Add release notes for v0.182.0
cPu1 Jun 7, 2024
40a6990
Merge pull request #7814 from eksctl-io/update-release-notes
cPu1 Jun 7, 2024
d8011b2
Prepare for next development iteration
eksctl-bot Jun 7, 2024
dca6eed
Merge pull request #7825 from eksctl-io/main-40a6990a0
cPu1 Jun 7, 2024
0f9e0eb
Make EKS 1.30 the default
cPu1 Jun 11, 2024
d4d12aa
Fix tests
cPu1 Jun 11, 2024
17a507a
Merge pull request #7827 from cPu1/eks-1.30-default
cPu1 Jun 11, 2024
c850f4d
Add release notes for v0.183.0
cPu1 Jun 11, 2024
a8f8fdf
Merge pull request #7824 from eksctl-io/update-release-notes
cPu1 Jun 11, 2024
96906a9
Prepare for next development iteration
eksctl-bot Jun 11, 2024
b5fce7c
Merge pull request #7829 from eksctl-io/main-a8f8fdf2e
cPu1 Jun 11, 2024
1cecd77
Stop using P2 instances which will be retired (#7826)
TiberiuGC Jun 11, 2024
4b62d1a
Schedule pods on a nodegroup on which no concurrent actions are execu…
TiberiuGC Jun 14, 2024
ad98541
use string in logging instead of wrapping error
moreandres Jun 15, 2024
3cbd926
Merge pull request #7838 from moreandres/logging-format-typo
cPu1 Jun 21, 2024
82e7e66
Fix SDK paginator mocks
cPu1 Jun 21, 2024
5aaba15
Merge pull request #7850 from cPu1/fix-sdk-mocks
cPu1 Jul 2, 2024
19bf1dd
Allow cluster creation without default networking addons
cPu1 May 27, 2024
d0fffd9
Install default addons as EKS managed addons
cPu1 May 27, 2024
809a0b6
Add integration tests and unit tests
cPu1 Jun 11, 2024
63a0cc0
Do not patch VPC CNI ServiceAccount to use IRSA if disableDefaultAddo…
cPu1 Jun 26, 2024
a7d1dc8
Honour the wait field when creating addons
cPu1 Jun 26, 2024
e566be3
Do not restart VPC CNI DaemonSet pods
cPu1 Jun 26, 2024
70923e6
Fix running kube-proxy on AL2023 nodes
cPu1 Jul 1, 2024
b4441d9
Fix addon integration tests
cPu1 Jul 1, 2024
679c513
Add documentation
cPu1 Jul 1, 2024
0d8d540
Fix integration tests
cPu1 Jul 1, 2024
3f8dff1
Reorder addons task
cPu1 Jul 2, 2024
3f57ee6
Fix tests
cPu1 Jul 3, 2024
13885f7
Fix CRUD test
cPu1 Jul 3, 2024
74ade5a
Merge pull request #7866 from cPu1/bare-cluster
cPu1 Jul 3, 2024
3715804
Add release notes for v0.184.0
cPu1 Jul 3, 2024
a6bc00f
Merge pull request #7828 from eksctl-io/update-release-notes
cPu1 Jul 3, 2024
9bb16fc
Prepare for next development iteration
eksctl-bot Jul 3, 2024
3fdd538
Merge pull request #7869 from eksctl-io/main-a6bc00f42
cPu1 Jul 3, 2024
df81750
fixed iam permissions for karpenter
siennathesane May 23, 2024
8ab26a7
Merge pull request #7778 from siennathesane/bug/7454
cPu1 Jul 4, 2024
d83fd8a
fix run as root efa device plugin bug
vsoch Feb 19, 2023
80e0c8d
Merge pull request #6302 from researchapps/update/efa-device-plugin
cPu1 Jul 4, 2024
45f89f6
add support for hpc7g arm images
vsoch Jun 26, 2023
9141821
update efa-device-plugin.yaml to one that workkks
vsoch Jun 26, 2023
f95076b
add additional hpc7g instance types
vsoch Jun 30, 2023
231194c
Merge pull request #6743 from researchapps/add/hpc7g-node-arm-support
cPu1 Jul 4, 2024
d329894
Add auto-ssm ami resolution for ubuntu
aciba90 Jun 25, 2024
9150dcb
Merge pull request #7851 from aciba90/ubuntu-ssm-ami-resolution-3224
cPu1 Jul 8, 2024
9c23afa
Avoid creating subnets in disallowed Availability Zone IDs
cPu1 Jul 4, 2024
c3ef646
Merge pull request #7870 from cPu1/avoid-disallowed-azs
cPu1 Jul 8, 2024
1754d27
Add release notes for v0.185.0
cPu1 Jul 8, 2024
94208c7
Merge pull request #7868 from eksctl-io/update-release-notes
cPu1 Jul 8, 2024
942c27b
Prepare for next development iteration
eksctl-bot Jul 8, 2024
fdf8ee9
Merge pull request #7874 from eksctl-io/main-94208c7b2
cPu1 Jul 8, 2024
deebe8b
Refactor: move bare cluster validation to NewCreateClusterLoader
cPu1 Jul 10, 2024
d0829b1
Merge pull request #7879 from cPu1/move-bare-cluster-validation
cPu1 Jul 10, 2024
07324eb
Retry throttling errors, disable retry rate-limiting
cPu1 Jul 10, 2024
b4af6ae
Merge pull request #7878 from eksctl-io/fix-sdk-retries
cPu1 Jul 10, 2024
4fcfce3
Allow limiting the number of nodegroups created in parallel
cPu1 Jul 11, 2024
e49dd91
Merge pull request #7884 from cPu1/nodegroup-parallelism
cPu1 Jul 11, 2024
62b8be7
Add release notes for v0.186.0
cPu1 Jul 11, 2024
c667581
Merge pull request #7881 from eksctl-io/update-release-notes
cPu1 Jul 11, 2024
8bf5808
Prepare for next development iteration
eksctl-bot Jul 11, 2024
4b2a630
Merge pull request #7886 from eksctl-io/main-c66758141
cPu1 Jul 11, 2024
ebc9920
Restrict `VPC.SecurityGroup` egress rules validations to self-managed…
TiberiuGC Jul 12, 2024
707c73b
Add release notes for v0.187.0 (#7885)
eksctl-bot Jul 16, 2024
02c41d5
Prepare for next development iteration (#7890)
eksctl-bot Jul 16, 2024
7f91b9d
Add GH workflow for automatically updating nvidia device plugin stati…
TiberiuGC Jul 29, 2024
7cf024a
Add support for Kuala Lumpur region (ap-southeast-5) (#7910)
TiberiuGC Jul 31, 2024
e85b0a9
Update nvidia-device-plugin to v0.16.0 (#7900)
eksctl-bot Jul 31, 2024
02e9d17
Bump github.com/docker/docker from 24.0.9+incompatible to 26.1.4+inco…
dependabot[bot] Jul 31, 2024
65f8193
Add release notes for v0.188.0 (#7889)
eksctl-bot Jul 31, 2024
014400f
Prepare for next development iteration (#7917)
eksctl-bot Jul 31, 2024
acf9ce1
Fix SSM unit tests
cPu1 Aug 16, 2024
afc40cd
Merge pull request #7935 from cPu1/fix-ssm-tests
cPu1 Aug 16, 2024
3aa7387
fix: resolve segfault in validateBareCluster
EmmEff Aug 6, 2024
8e680a0
Merge pull request #7927 from EmmEff/resolve-segfault-with-vpc-cni-di…
cPu1 Aug 16, 2024
5374282
Skip creating OIDC manager for Outposts clusters
cPu1 Aug 16, 2024
9fa8fc9
Merge pull request #7934 from cPu1/outposts-oidc
cPu1 Aug 16, 2024
cf5ad73
Add release notes for v0.189.0
cPu1 Aug 16, 2024
c9afc42
Merge pull request #7916 from eksctl-io/update-release-notes
cPu1 Aug 19, 2024
40ea06f
Prepare for next development iteration
eksctl-bot Aug 19, 2024
fc24e94
Merge pull request #7944 from eksctl-io/main-c9afc4260
cPu1 Aug 21, 2024
cfb7c45
Bump github.com/docker/docker
dependabot[bot] Aug 16, 2024
ab43e91
Merge pull request #7936 from eksctl-io/dependabot/go_modules/github.…
cPu1 Sep 4, 2024
3146e25
Bump jinja2 from 3.1.3 to 3.1.4 in /userdocs
dependabot[bot] May 6, 2024
185270d
Merge pull request #7748 from eksctl-io/dependabot/pip/userdocs/jinja…
cPu1 Sep 4, 2024
b6070e5
Add release notes for v0.190.0
cPu1 Sep 4, 2024
3fccc8e
Merge pull request #7945 from eksctl-io/update-release-notes
cPu1 Sep 4, 2024
f9b5143
Prepare for next development iteration
eksctl-bot Sep 4, 2024
49aff8f
Merge pull request #7966 from eksctl-io/main-3fccc8ed8
cPu1 Sep 4, 2024
fe80323
Prepare for next development iteration
eksctl-bot Sep 4, 2024
ceae162
Merge pull request #7967 from eksctl-io/main-3fccc8ed8
cPu1 Sep 11, 2024
52300c3
Add support for EKS 1.31 (#7973)
TiberiuGC Sep 26, 2024
c736924
Add release notes for v0.191.0 (#7965)
eksctl-bot Sep 26, 2024
a56ce0d
Prepare for next development iteration
eksctl-bot Sep 26, 2024
5546810
Merge pull request #7975 from eksctl-io/main-c736924d6
cPu1 Sep 26, 2024
46c7673
cleanup efa installer archive before install
vsoch Jul 29, 2023
2079032
efa-installer: remove archive in 2023 files
vsoch Aug 21, 2024
27ba59a
Merge pull request #6870 from researchapps/cleanup-efa-installer-archive
cPu1 Oct 7, 2024
d70fff1
Disallow `overrideBootstrapCommand` and `preBootstrapCommands` for MN…
TiberiuGC Oct 8, 2024
486acdf
Add support for EKS accelerated AMIs based on AL2023 (#7996)
TiberiuGC Oct 11, 2024
65610b3
Add release notes for v0.192.0 (#7974)
eksctl-bot Oct 11, 2024
56876e0
Prepare for next development iteration (#7997)
eksctl-bot Oct 12, 2024
8110a64
Add support for M8g instance types
cPu1 Oct 17, 2024
7da79c5
Merge pull request #8001 from cPu1/m8g-support
cPu1 Oct 17, 2024
311f65e
Correct version drift in cluster-upgrade.md
larvacea Oct 8, 2024
2292b90
Merge pull request #7994 from larvacea/main
cPu1 Oct 17, 2024
26bc3be
Add release notes for v0.193.0
cPu1 Oct 17, 2024
19cb88b
Merge pull request #8002 from eksctl-io/update-release-notes
cPu1 Oct 18, 2024
3bb5a69
Prepare for next development iteration
eksctl-bot Oct 18, 2024
65428f9
Merge pull request #8003 from eksctl-io/main-19cb88bf5
cPu1 Oct 18, 2024
d9c9b2e
Fix missing ELB listener attribute actions required for AWS Load Bala…
jonathanfoster Oct 5, 2024
18344d8
Merge pull request #7988 from jonathanfoster/fix-missing-elb-listener…
cPu1 Oct 21, 2024
b49b1b4
Support EKS zonal shift config
cPu1 Sep 26, 2024
ba7bfae
Fix tests
cPu1 Oct 22, 2024
b1f9f93
Merge pull request #8005 from cPu1/zonal-shift
cPu1 Oct 22, 2024
8690077
Add release notes for v0.194.0
cPu1 Oct 22, 2024
02ef28e
Merge pull request #8004 from eksctl-io/update-release-notes
cPu1 Oct 22, 2024
e7d5785
Merge remote-tracking branch 'origin/upstrem0194' into CON-22743_add_…
yehielnetapp Nov 6, 2024
dc5bcd3
after clean compile
yehielnetapp Nov 6, 2024
37cfc24
fix merge .. cloudformation error while creating ocean nodegroup
yehielnetapp Nov 7, 2024
1520053
actual work to add field in ocean cluster config
yehielnetapp Nov 10, 2024
3a97cd0
restore .goreleaser.yml to root
yehielnetapp Nov 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix create cluster when iam.podIdentityAssociations is unset
  • Loading branch information
cPu1 committed May 30, 2024

Verified

This commit was signed with the committer’s verified signature.
yunakim714 Yuna Kim
commit aeac061eb1ddc9154aca8a4bcc8996393b8f9bdf
6 changes: 4 additions & 2 deletions pkg/ctl/cmdutils/configfile.go
Original file line number Diff line number Diff line change
@@ -327,8 +327,10 @@ func NewCreateClusterLoader(cmd *Cmd, ngFilter *filter.NodeGroupFilter, ng *api.
suggestion := fmt.Sprintf("please add %q addon to the config file", api.PodIdentityAgentAddon)
return api.ErrPodIdentityAgentNotInstalled(suggestion)
}
if err := validatePodIdentityAssociationsForConfig(clusterConfig, true); err != nil {
return err
if clusterConfig.IAM != nil && len(clusterConfig.IAM.PodIdentityAssociations) > 0 {
if err := validatePodIdentityAssociations(clusterConfig.IAM.PodIdentityAssociations, true); err != nil {
return err
}
}
}

6 changes: 4 additions & 2 deletions pkg/ctl/cmdutils/pod_identity_association.go
Original file line number Diff line number Diff line change
@@ -114,8 +114,11 @@ func validatePodIdentityAssociationsForConfig(clusterConfig *api.ClusterConfig,
if clusterConfig.IAM == nil || len(clusterConfig.IAM.PodIdentityAssociations) == 0 {
return errors.New("no iam.podIdentityAssociations specified in the config file")
}
return validatePodIdentityAssociations(clusterConfig.IAM.PodIdentityAssociations, isCreate)
}

for i, pia := range clusterConfig.IAM.PodIdentityAssociations {
func validatePodIdentityAssociations(podIdentityAssociations []api.PodIdentityAssociation, isCreate bool) error {
for i, pia := range podIdentityAssociations {
path := fmt.Sprintf("podIdentityAssociations[%d]", i)
if pia.Namespace == "" {
return fmt.Errorf("%s.namespace must be set", path)
@@ -149,7 +152,6 @@ func validatePodIdentityAssociationsForConfig(clusterConfig *api.ClusterConfig,
}
}
}

return nil
}