Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failures on windows and macos #99

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix CI failures on windows and macos #99

merged 2 commits into from
Dec 13, 2024

Conversation

miclegr
Copy link
Contributor

@miclegr miclegr commented Dec 13, 2024 •
edited
Loading

Description

  • Looks like there's something wrong with cmake installation on the windows github action image (here). Cmake is already installed anyway, so we don't need it install it explicitly
  • Bumped macos image from version 12 to latest, since macos-12 has been removed

@miclegr miclegr marked this pull request as ready for review December 13, 2024 07:27
@miclegr miclegr changed the title Fix windows build Fix CI: windows build failing because of cmake installation Dec 13, 2024
@miclegr miclegr changed the title Fix CI: windows build failing because of cmake installation Fix CI failures on windows and macos Dec 13, 2024
stephen29xie
stephen29xie approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@stephen29xie stephen29xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miclegr miclegr merged commit fefed3d into spotify:main Dec 13, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen29xie stephen29xie stephen29xie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miclegr @stephen29xie