-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Python bindings to Nanobind. #92
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice! Nice to see a lot of the pybind fluff go away. Ruff also seems like a solid choice as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build locally with this new setup 👍. The migration in the Python bindings contains a breaking change though.
Some places to clean up:
- Update
CONTRIBUTING.md
- the Building Python section contains a reference to the removed
setup.py
- The Troubleshooting section contains a reference to
pybind11
- the Building Python section contains a reference to the removed
python/dev-requirements.txt
containspybind11
andpybind11-stubgen
Tests still pass.
Still need to ensure that CI/CD works as expected, resulting wheels are smaller, and - most importantly - that docstring generation and type hint generation work without my absolutely awful hack of a script.