Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks improvements #83

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Benchmarks improvements #83

merged 1 commit into from
Aug 2, 2024

Conversation

miclegr
Copy link
Contributor

@miclegr miclegr commented Aug 2, 2024

Description

In this PR we will:

  • add benchmarks for voyager.Space.InnerProduct
  • make all benchmarks fully reproducible by setting random_seed in voyager.Index and setting num_threads in voyager.Index.add_items
  • increase number of vector used to estimate recall

Checklist

  • My code follows the code style of this project.
  • I have added and/or updated appropriate documentation (if applicable).
  • All new and existing tests pass locally with these changes.
  • I have run static code analysis (if available) and resolved any issues.
  • I have considered backward compatibility (if applicable).
  • I have confirmed that this PR does not introduce any security vulnerabilities.

Additional Comments

@miclegr miclegr marked this pull request as ready for review August 2, 2024 15:59
dylanrb123
dylanrb123 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@dylanrb123 dylanrb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks!

@miclegr miclegr merged commit 04fa382 into spotify:main Aug 2, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanrb123 dylanrb123 dylanrb123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miclegr @dylanrb123