call C++ destructor instead of free #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanrb123
commented
Sep 1, 2023
| @@ -277,6 +277,15 @@ public void close() throws IOException { | |||
| nativeDestructor(); | |||
| } | |||
|
|
|||
| @Override | |||
| protected void finalize() throws Throwable { | |||
There was a problem hiding this comment.
this is called by the JVM on garbage collection so the destructor will be called even if close isn't called
markkohdev
approved these changes
Sep 1, 2023
|
Tested this locally by building the JAR and loading that in a small java app that loads a large (14gb) index, closes it, and then just hangs. Monitoring the mem usage I was able to see it reclaim the memory as expected. Before this change even after the index was closed the memory was not released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freewill just free the memory for the pointer itself, by calling the native destructor it should actually free the underlying memory.