Rewatch

[honnix]

Hey, I just made a Pull Request!

Description

This reverts #734

There are cases that fabric8 won't reconnect on itself, e.g. in case of HTTP_GONE.

There was an attempted fix in upstream, but eventually got rolled back because it broke the contract.

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

• Changes are covered by unit test
• All tests pass
• Code coverage check passes
• Error handling is tested
• Errors are handled at the appropriate layer
• Errors that cannot be handled where they occur are propagated
• (optional) Changes are covered by system test
• Relevant documentation updated
• This PR has NO breaking change to public API
• This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

• This PR has been incorporated in release note for the coming version
• Risky changes introduced by this PR have been all considered

[codecov]

Codecov Report

Merging #810 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #810      +/-   ##
============================================
- Coverage     91.44%   91.36%   -0.08%     
  Complexity     1906     1906              
============================================
  Files           176      176              
  Lines          7468     7482      +14     
  Branches        456      456              
============================================
+ Hits           6829     6836       +7     
- Misses          527      532       +5     
- Partials        112      114       +2

[honnix]

This is not necessarily needed because fabric8 force closes it anyway. But to be on the safe side, we do it again and it is idempotent.