Use burningwave lib to export javac packages from module #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that Burningwave does not seem to support aarch64, so this would now work for folks with arm linux laptops and m1 macbooks etc. |
|
The burningwave lib feels a bit like overkill for this, and forking the plugin is more flexible, closing this and going with #140 |
|
At least this little part worked fine with an aarch64 JDK. |
|
Will dig into this a bit further. |
|
Trying to get some more clues on how this works and when/if it might break burningwave/jvm-driver#2 |
|
If I change |
|
Went with forking. #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to solve the problem of running the plugin with Java 17, but without forking to add JVM args.
Could try hiding this behind a setting as a start, in case it causes problems....