Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping of sourceDirectory or testSourceDirectory #128

Merged
merged 6 commits into from
Sep 30, 2022

Conversation

camac
Copy link
Contributor

@camac camac commented Feb 16, 2022

Fixes #31

Adds 2 extra configuration options controlling whether to skip relevant
directories:

  • skipSourceDirectory
  • skipTestSourceDirectory

Tests added:

  • check_skipsourcedirectory: Tests that sourceDirectory is skipped
    for check goal when skipSourceDirectory is true.
    sourceDirectory includes unformatted code so it would fail if not
    skipped.
  • check_skiptestsourcedirectory: Tests that testSourceDirectory is
    skipped for check goal when skipTestSourceDirectory is true.
    testSourceDirectory includes unformatted code so it would
    fail if not skipped.
  • skipsourcedirectory: Tests that sourceDirectory files are not formatted
    with format goal when skipSourceDirectory is true.
  • skiptestsourcedirectory: Tests that testSourceDirectory files are not
    formatted with format goal when skipTestSourceDirectory is true.

Fixes spotify#31

Adds 2 extra configuration options controlling whether to skip relevant
directories:

- skipSourceDirectory
- skipTestSourceDirectory

Tests added:

- check_skipsourcedirectory: Tests that sourceDirectory is skipped
  for check goal when skipSourceDirectory is true.
  sourceDirectory includes unformatted code so it would fail if not
  skipped.
- check_skiptestsourcedirectory: Tests that testSourceDirectory is
  skipped for check goal when skipTestSourceDirectory is true.
  testSourceDirectory includes unformatted code so it would
  fail if not skipped.
- skipsourcedirectory: Tests that sourceDirectory files are not formatted
  with format goal when skipSourceDirectory is true.
- skiptestsourcedirectory: Tests that testSourceDirectory files are not
  formatted with format goal when skipTestSourceDirectory is true.


Co-authored-by: Sean Flanigan <[email protected]>
@camac camac force-pushed the skipdirectories branch from 80ccd46 to 60d2dfa Compare March 1, 2022 02:35
@camac camac marked this pull request as draft March 1, 2022 02:38
@klaraward
Copy link
Contributor

klaraward commented Sep 20, 2022

Thanks @camac :)

Could you also add invoker.properties files for these tests? Might not be the most interesting thing to test via the invoker test mechanism but still nice to keep things consistent.

@camac
Copy link
Contributor Author

camac commented Sep 30, 2022

Thanks @klaraward, I have added invoker.properties, switched to using loadMojo, and update the groupId in the test pom.xml's to be com.spotify.fmt

@camac camac marked this pull request as ready for review September 30, 2022 06:22
@camac camac requested a review from klaraward September 30, 2022 06:22
@caesar-ralf caesar-ralf merged commit 1cf19c0 into spotify:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please allow skip of sourceDirectory or testSourceDirectory
3 participants