-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow skipping of sourceDirectory or testSourceDirectory #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spotify#31 Adds 2 extra configuration options controlling whether to skip relevant directories: - skipSourceDirectory - skipTestSourceDirectory Tests added: - check_skipsourcedirectory: Tests that sourceDirectory is skipped for check goal when skipSourceDirectory is true. sourceDirectory includes unformatted code so it would fail if not skipped. - check_skiptestsourcedirectory: Tests that testSourceDirectory is skipped for check goal when skipTestSourceDirectory is true. testSourceDirectory includes unformatted code so it would fail if not skipped. - skipsourcedirectory: Tests that sourceDirectory files are not formatted with format goal when skipSourceDirectory is true. - skiptestsourcedirectory: Tests that testSourceDirectory files are not formatted with format goal when skipTestSourceDirectory is true. Co-authored-by: Sean Flanigan <[email protected]>
Thanks @camac :) Could you also add |
klaraward
reviewed
Sep 20, 2022
klaraward
reviewed
Sep 20, 2022
Thanks @klaraward, I have added |
caesar-ralf
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
Adds 2 extra configuration options controlling whether to skip relevant
directories:
Tests added:
for check goal when skipSourceDirectory is true.
sourceDirectory includes unformatted code so it would fail if not
skipped.
skipped for check goal when skipTestSourceDirectory is true.
testSourceDirectory includes unformatted code so it would
fail if not skipped.
with format goal when skipSourceDirectory is true.
formatted with format goal when skipTestSourceDirectory is true.