Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Fix for #978: Docker client does not honour the -Dhttp.nonProxyHosts … #986

Merged
merged 2 commits into from
Apr 12, 2018

Conversation

beskow
Copy link

@beskow beskow commented Feb 28, 2018

…setting when it builds an image.

@codecov-io
Copy link

codecov-io commented Feb 28, 2018

Codecov Report

Merging #986 into master will increase coverage by 0.07%.
The diff coverage is 68.42%.

@@             Coverage Diff              @@
##             master     #986      +/-   ##
============================================
+ Coverage     67.46%   67.53%   +0.07%     
- Complexity      749      753       +4     
============================================
  Files           170      170              
  Lines          3123     3133      +10     
  Branches        354      358       +4     
============================================
+ Hits           2107     2116       +9     
  Misses          862      862              
- Partials        154      155       +1

Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you!

@mattnworb mattnworb requested a review from davidxia February 28, 2018 15:06
@beskow
Copy link
Author

beskow commented Apr 10, 2018

Any news regarding this pull request?

@mattnworb mattnworb merged commit 80c41ef into spotify:master Apr 12, 2018
@beskow beskow deleted the #978-nonProxyHosts branch May 22, 2018 08:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants