This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
#890 fix for proxy usage ("Expected authority at index 7" error) #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deki
changed the title
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
============================================
+ Coverage 67.43% 67.53% +0.09%
- Complexity 748 749 +1
============================================
Files 170 170
Lines 3117 3117
Branches 352 352
============================================
+ Hits 2102 2105 +3
+ Misses 863 860 -3
Partials 152 152 |
|
@davidxia why this has not been merged before the 8.11.0 release? :-( |
|
Sorry, I must've missed this. Thanks for fixing. |
davidxia
approved these changes
Jan 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the last optimization in my PR #903 causes "Expected authority at index 7" error due to missing brackets. I've fixed that and also added a unittest for it.