This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
make ImageInfo.RootFS nullable #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RootFS` was added to the ImageInfo / inspectImage response in version 1.23 of the Docker Remote API (for Docker version 1.11). Earlier versions of the API do not have this field present in ImageInfo. We caught this because we run tests for spotify/helios on CircleCI which uses Docker 1.10.
mattnworb
force-pushed
the
mattbrown/nullable-rootfs
branch
from
277fea8 to
c0e4a61
Compare
davidxia
approved these changes
Aug 8, 2017
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
============================================
+ Coverage 65.92% 66.46% +0.54%
- Complexity 737 745 +8
============================================
Files 166 166
Lines 3140 3140
Branches 357 357
============================================
+ Hits 2070 2087 +17
+ Misses 914 898 -16
+ Partials 156 155 -1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RootFSwas added to the ImageInfo / inspectImage response in version1.23 of the Docker Remote API (for Docker version 1.11). Earlier
versions of the API do not have this field present in ImageInfo.
We caught this because we run tests for spotify/helios on CircleCI which
uses Docker 1.10.