Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Add RootFS property to InspectImage response #835

Merged
merged 3 commits into from
Jul 21, 2017

Conversation

BastianVoigt
Copy link
Contributor

No description provided.

Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! Any idea if this is a recent addition to the ImageInfo response, or something that was missed all along?

@BastianVoigt
Copy link
Contributor Author

Not sure, probably it was added somewhere around docker version 1.10 when they changed the way images and layers are stored on disk

@BastianVoigt
Copy link
Contributor Author

BastianVoigt commented Jul 21, 2017

So I finally figured out how to solve the license issue. Two spaces were missing at the end of the line :-(. @mattnworb any idea why travis failed on JDK7 & Docker 17.04? To me it does not look like the failure was triggered by my change

@codecov-io
Copy link

codecov-io commented Jul 21, 2017

Codecov Report

Merging #835 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #835      +/-   ##
===========================================
+ Coverage     66.48%   66.5%   +0.02%     
- Complexity      740     742       +2     
===========================================
  Files           165     166       +1     
  Lines          3130    3132       +2     
  Branches        357     357              
===========================================
+ Hits           2081    2083       +2     
  Misses          892     892              
  Partials        157     157

@mattnworb
Copy link
Member

@BastianVoigt sorry for the headache about the license headers, you can also just run mvn license:update-file-header to have the same plugin automatically update files.

As for the failing test, I think it was just a flaky integration test, I re-ran it and it passed.

@mattnworb mattnworb merged commit da5c99d into spotify:master Jul 21, 2017
@mattnworb
Copy link
Member

thanks again for the PR!

@BastianVoigt
Copy link
Contributor Author

What do you think when it can be released?

@BastianVoigt
Copy link
Contributor Author

@mattnworb do you think you can release this anytime soon? Or should I build my own release from the fork. Bcs I need to use this feature in my project. Thanks!

@mattnworb
Copy link
Member

I'll kick off a release today

@mattnworb
Copy link
Member

8.8.2 should be on it's way to Maven central now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants