-
Notifications
You must be signed in to change notification settings - Fork 550
Add RootFS property to InspectImage response #835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR! Any idea if this is a recent addition to the ImageInfo response, or something that was missed all along?
Not sure, probably it was added somewhere around docker version 1.10 when they changed the way images and layers are stored on disk |
So I finally figured out how to solve the license issue. Two spaces were missing at the end of the line :-(. @mattnworb any idea why travis failed on JDK7 & Docker 17.04? To me it does not look like the failure was triggered by my change |
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
===========================================
+ Coverage 66.48% 66.5% +0.02%
- Complexity 740 742 +2
===========================================
Files 165 166 +1
Lines 3130 3132 +2
Branches 357 357
===========================================
+ Hits 2081 2083 +2
Misses 892 892
Partials 157 157 |
@BastianVoigt sorry for the headache about the license headers, you can also just run As for the failing test, I think it was just a flaky integration test, I re-ran it and it passed. |
thanks again for the PR! |
What do you think when it can be released? |
@mattnworb do you think you can release this anytime soon? Or should I build my own release from the fork. Bcs I need to use this feature in my project. Thanks! |
I'll kick off a release today |
8.8.2 should be on it's way to Maven central now |
No description provided.