This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Make UpdateStatus.completedAt nullable #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
requested review from
mattnworb,
mavenraven and
caipre
and removed request for
mattnworb
mattnworb
approved these changes
Jul 20, 2017
Add unit test. Fixes #832
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
=========================================
Coverage 66.48% 66.48%
Complexity 740 740
=========================================
Files 165 165
Lines 3130 3130
Branches 357 357
=========================================
Hits 2081 2081
Misses 892 892
Partials 157 157 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test.
Fixes #832