Fixes for docker 17.06.0 #825
Conversation
…tted for bad image anymore.
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
============================================
+ Coverage 66.21% 66.38% +0.17%
- Complexity 737 738 +1
============================================
Files 165 165
Lines 3123 3130 +7
Branches 357 357
============================================
+ Hits 2068 2078 +10
+ Misses 897 893 -4
- Partials 158 159 +1 |
|
Is there a way to get the "fixed" jar somehow? with tag .... "alpha/beta"? |
| @@ -5099,13 +5117,22 @@ public void testCreateServiceWithSecretHostnameHostsAndHealthcheck() throws Exce | |||
| .build(); | |||
|
|
|||
| final String[] commandLine = {"ping", "-c4", "localhost"}; | |||
| final long interval = dockerApiVersionLessThan("1.30") ? 30L : 30000000L; | |||
There was a problem hiding this comment.
did they change the unit in between api versions? 😬
There was a problem hiding this comment.
I think they did, yes. Or maybe they were lenient about the units before, and started being more strict. I think these were always intended to be in nanoseconds (at least our javadoc says they are in nanoseconds).
|
I can add something to the change log, but I want to be careful about the wording. I didn't actually bring us up to full compatibility with the new API. I mostly just made sure the tests we run are asserting accurate stuff, and in a couple places I made small modifications to the code where the tests exposed things that were broken. |
|
@johnflavin sounds good to me, I think any extra info in the changelog is helpful and better than none. Thanks! |
In fixing #822, I saw that a lot of tests were failing on docker
17.06.0. I fixed all the errors in both tests and code so that the tests run cleanly on my machine.However, we can't test
17.06.0on travis yet because it isn't in the docker apt repo.