This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Update SwarmJoin non/nullable fields #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
=========================================
Coverage ? 66.04%
Complexity ? 713
=========================================
Files ? 162
Lines ? 3060
Branches ? 350
=========================================
Hits ? 2021
Misses ? 884
Partials ? 155 |
|
Is there an easy way to write a test for this? |
|
@davidxia An integration test would need a second node, I do not know enough about the test infrastructure to know how feasible/easy it is. I would need guidance on this. |
|
Yea I thought an integration test would be hard. How about a unit test then? See DefaultDockerClientUnitTest. The test failure is caused by https://github.com/spotify/docker-client/pulls |
|
@davidxia I added a unit test for joinSwarm. Not sure if it makes sense to add more tests for each nullable fields as it would just test the Nullable annotation handling. Wdyt? |
davidxia
approved these changes
Jun 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwarmJoin.AdvertiseAddr field is Nullable but RemoteAddrs and JoinToken are not