This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
fix NPE in MultiRegistryAuthSupplier #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
approved these changes
Jun 5, 2017
it never checks if authForBuild returns null
mattnworb
force-pushed
the
mattbrown/fix-npe-multiauth
branch
from
7562a62 to
aa8a023
Compare
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
============================================
- Coverage 65.9% 65.88% -0.03%
- Complexity 697 698 +1
============================================
Files 158 158
Lines 3021 3022 +1
Branches 346 347 +1
============================================
Hits 1991 1991
Misses 876 876
- Partials 154 155 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it never checks if authForBuild returns null