This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
remove com.spotify:logging #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the library is not actually used in tests - I think 1ce1cdb (where it was added) really meant to use logback directly.
mattnworb
force-pushed
the
mattbrown/spotify-logging
branch
from
821ae49 to
aa9a415
Compare
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=========================================
Coverage 65.89% 65.89%
Complexity 671 671
=========================================
Files 158 158
Lines 2926 2926
Branches 335 335
=========================================
Hits 1928 1928
Misses 850 850
Partials 148 148 |
davidxia
approved these changes
May 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the library is not actually used in tests - I think 1ce1cdb (where it
was added) really meant to use logback directly.