This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
add note pointing contributors to DefaultDockerClientUnitTest #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document that we would prefer to have more unit tests than integration tests for new functionality going forward, now that DefaultDockerClientUnitTest uses a mock web server where we can capture and stub HTTP requests/responses.
davidxia
approved these changes
May 23, 2017
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
=========================================
Coverage 65.56% 65.56%
Complexity 655 655
=========================================
Files 153 153
Lines 2878 2878
Branches 335 335
=========================================
Hits 1887 1887
Misses 844 844
Partials 147 147 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that we would prefer to have more unit tests than integration
tests for new functionality going forward, now that
DefaultDockerClientUnitTest uses a mock web server where we can capture
and stub HTTP requests/responses.