This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Only copy volumes if non-null #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Continue to review full report at Codecov.
|
|
Waiting for #605 to be merged, then will rebase this and test again. EDIT: Rebased. |
|
Seems like test failures are unrelated to my code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603.
I didn't see a way to add a test for this issue. The issue only occurs if there are no volumes; it would be hard to guarantee that no other volume tests have already run and created volumes, and I didn't think it would be safe to just delete all of the existing volumes in my test.