This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Use AuthConfig for service creation in swarm mode (closes #523) #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmandalidis
commented
Oct 11, 2016
dmandalidis
commented
- Removal of obsolete ServiceCreateOptions
Current coverage is 45.92% (diff: 100%)@@ master #524 diff @@
==========================================
Files 131 130 -1
Lines 4306 4285 -21
Methods 0 0
Messages 0 0
Branches 638 634 -4
==========================================
Hits 1968 1968
+ Misses 2149 2129 -20
+ Partials 189 188 -1
|
|
@davidxia hey it's me again (if you please). Thanks in advance |
- Removal of obsolete ServiceCreateOptions
|
@davidxia @mattnworb Can you please check this? |
davidxia
approved these changes
Nov 9, 2016
|
@dmandalidis Thanks for the PR. Sorry for the delay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.