This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Relocate remaining packages that are included in shaded jar #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidHaunsch
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
=========================================
Coverage 70.17% 70.17%
Complexity 791 791
=========================================
Files 178 178
Lines 3772 3772
Branches 393 393
=========================================
Hits 2647 2647
Misses 960 960
Partials 165 165 |
|
Any chance this PR get's merged? |
davidxia
approved these changes
Jan 14, 2019
mattnworb
approved these changes
Jan 15, 2019
|
Nice, thanks! |
|
@DavidHaunsch just released as 8.15.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1096 (comment), I'm trying here to relocate all remaining packages that are in the shaded jar but not relocated yet.
This will solves problems where a docker-client doesn't get the version from inside the shaded jar but the one that appears first on classpath.