Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Change maven-compiler-plugin source and target from 1.7 to 1.8 #1081

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Oct 2, 2018

Change maven-compiler-plugin source and target from 1.7 to 1.8

to prepare for Java 8.
JAR should still be compatible with JRE 1.7.

Set Travis CI JDK to oraclejdk8.

fixes #756

@mattnworb
Copy link
Member

could you also add something to the changelog? I think it would be good to bump the version too, like to 8.14 or whatever.

@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #1081 into master will increase coverage by 2.78%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1081      +/-   ##
============================================
+ Coverage     67.08%   69.86%   +2.78%     
  Complexity      789      789              
============================================
  Files           178      178              
  Lines          3287     3786     +499     
  Branches        385      392       +7     
============================================
+ Hits           2205     2645     +440     
- Misses          917      972      +55     
- Partials        165      169       +4

Copy link
Member

@mattnworb mattnworb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it’s conpletely necessary to do a full version bump, since there’s no code API change. 8.14 would make sense to me too.

@davidxia
Copy link
Contributor Author

davidxia commented Oct 2, 2018

Ah that's true. I'm not using any java 8 language features yet. I'll change to 8.14 then.

@davidxia davidxia changed the title Set Java version of source and runtime to 8 Change maven-compiler-plugin source and target from 1.7 to 1.8 Oct 2, 2018
to prepare for Java 8.
JAR should still be compatible with JRE 1.7.

Set Travis CI JDK to `oraclejdk8`.

fixes #756
@davidxia davidxia merged commit 5256d39 into master Oct 2, 2018
@davidxia davidxia deleted the dxia/java-8 branch October 2, 2018 22:13
@diemol
Copy link
Contributor

diemol commented Oct 13, 2018

Thanks for moving it to Java 8 @davidxia!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

start requiring Java 8?
4 participants