This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
build on jdk10, fix java 9+ incompatibilities #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I intended to update the Travis config to build on Java 10 and/or 11, but it looks like neither are available yet. We should consider dropping some of the docker versions used in the build matrix, as building with several additional JDKs just multiples the number of builds to 15 now - Docker 1.12.6 was released on 2017-01-10 for instance. |
|
Looks like jdk10 is supported via |
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
=========================================
Coverage ? 70.14%
Complexity ? 786
=========================================
Files ? 177
Lines ? 3762
Branches ? 390
=========================================
Hits ? 2639
Misses ? 959
Partials ? 164 |
|
Looks like I misread the docs, |
davidxia
added a commit
that referenced
this pull request
Oct 2, 2018
This library was originally using Java 7. Java 7 had `Date` objects with only millisecond resolution. This was a problem when translating timestamps with nanosecond precision from the Docker API to `Date`. This library is on Java 8 now which supports nanosecond resolution. This PR fixes the findbugs error here #1068. See build logs https://travis-ci.org/spotify/docker-client/jobs/426781589.
davidxia
added a commit
that referenced
this pull request
Oct 2, 2018
This library was originally using Java 7. Java 7 had `Date` objects with only millisecond precision. This was a problem when translating timestamps with nanosecond precision from the Docker API to `Date`. This library is on Java 8 now whose `Date` translates a timestamp with nanosecond precision correctly. Removing `DockerDateFormat` fixes the findbugs error here #1068. See build logs https://travis-ci.org/spotify/docker-client/jobs/426781589.
mattnworb
force-pushed
the
modern-jdks
branch
2 times, most recently
from
0174b1a to
d713e54
Compare
|
re-did this PR to just add |
first version with support for Java 9 is 0.7.8: https://groups.google.com/forum/#!msg/jacoco/Zf0Cwj13G2g/wpyrYAEECAAJ this commit updates to latest available
mattnworb
changed the title
davidxia
approved these changes
Oct 3, 2018
|
Seems like the only real issue with Java 9 (fixed in a commit above) is that Jersey classes throw an Exception when loaded - Java 9 removes the |
Closed
|
the failing test is for a single build in the test matrix with a known-flaky test. Otherwise I think this change will unblock some other projects from addressing Java 9 compatibility problems. |
|
after re-running some flaky tests 10x, the build is green ✅ |
|
same problem as @mattnworb with Java 11 (tried with shaded jar as well) openjdk 11.0.1 2018-10-16 |
|
@renannprado have you tried version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.