ensure build() works as expected when dockerAuth is true

spotify · May 23, 2017 · d5cffbc · d5cffbc
1 parent e228b4f
commit d5cffbc
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/main/java/com/spotify/docker/client/DefaultDockerClient.java b/src/main/java/com/spotify/docker/client/DefaultDockerClient.java
@@ -2630,7 +2630,9 @@ public boolean dockerAuth() {
      *
      * @param dockerAuth tells if Docker auth info should be used
      * @return Builder
+     * @deprecated in favor of {@link #registryAuthSupplier(RegistryAuthSupplier)}
      */
+    @Deprecated
     public Builder dockerAuth(final boolean dockerAuth) {
       this.dockerAuth = dockerAuth;
       return this;
@@ -2646,7 +2648,7 @@ public RegistryAuth registryAuth() {
      * @param registryAuth RegistryAuth object
      * @return Builder
      *
-     * @deprecated in favor of registryAuthSupplier
+     * @deprecated in favor of {@link #registryAuthSupplier(RegistryAuthSupplier)}
      */
     @Deprecated
     public Builder registryAuth(final RegistryAuth registryAuth) {
@@ -2676,9 +2678,9 @@ public Builder registryAuthSupplier(final RegistryAuthSupplier registryAuthSuppl
     }
 
     public DefaultDockerClient build() {
-      if (dockerAuth) {
+      if (dockerAuth && registryAuthSupplier == null && registryAuth == null) {
         try {
-          this.registryAuth = RegistryAuth.fromDockerConfig().build();
+          registryAuth(RegistryAuth.fromDockerConfig().build());
         } catch (IOException e) {
           log.warn("Unable to use Docker auth info", e);
         }