Support Swift 5.1 toolchains #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 96.96% 96.29% -0.68%
==========================================
Files 36 36
Lines 858 864 +6
==========================================
Hits 832 832
- Misses 26 32 +6
Continue to review full report at Codecov.
|
dflems
approved these changes
Jun 4, 2019
|
Gonna merge this. The rule that coverage can never ever ever be decreased (even by 0.68%) is a bit egregious. |
|
cc @jeppes |
|
More importantly, it didn’t add any actual code and the code that is there can never be executed, so it’s quite hard to cover. |
|
I think it's that So coverage did go down, just barely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older toolchains,
==must have a dummy return statement. In newer ones, it must not. (Having one generates an unreachable code warning, and we treat warnings as errors.)I’d like to formally deprecate
NoEffectin favour ofNever. Unfortunately, there is no way to make an availability attribute conditional on the version of Swift used by the consumer of the library, so as long as we support Swift 4.x (whereNeverisn’tHashableorEquatable) we can’t do this.If such a deprecation isn’t controversial, I guess we can document it as soft-deprecated.