Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route enum cases without associated values #194

Merged
merged 1 commit into from
May 31, 2022

Conversation

kmcbride
Copy link
Collaborator

This resolves a small annoyance with effect enums having to conform to Equatable in order to use the .routeCase(…) API.

This change is backwards compatible and doesn't affect existing implementations.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #194 (d2ff1e6) into master (2170f40) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   95.15%   95.35%   +0.19%     
==========================================
  Files          42       42              
  Lines        1425     1421       -4     
==========================================
- Hits         1356     1355       -1     
+ Misses         69       66       -3     
Flag Coverage Δ
macspm 95.35% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
MobiusCore/Source/EffectHandlers/EnumRoute.swift 100.00% <100.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2170f40...d2ff1e6. Read the comment docs.

Copy link
Contributor

@rastersize rastersize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is awesome

@kmcbride kmcbride merged commit d0ea9c2 into spotify:master May 31, 2022
@kmcbride kmcbride deleted the route-case-void branch May 31, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants