Prevent forwarding viewConnectable inputs after dispose #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 94.97% 95.15% +0.17%
==========================================
Files 42 42
Lines 1414 1425 +11
==========================================
+ Hits 1343 1356 +13
+ Misses 71 69 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rastersize
previously approved these changes
Apr 25, 2022
rastersize
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something overlooked in #190 is that the connection disposal was previously executed only after all input forwarding occurred because it was scheduled last.
There needed to be one additional state check in order for the new behavior to also honor the connection contract of not forwarding inputs after dispose. I've added this check and restored a small amount of pre-#190 functionality.
I tested this fix with features that had a number of tests failing as a result of trying to pull in the changes from #190 and it looks to be passing now.