Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CasePath object-constrained existential extraction #184

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

kmcbride
Copy link
Collaborator

@kmcbride kmcbride commented Jan 2, 2022

Ports the fix for the issue we encountered.

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #184 (7fdc12f) into master (b01c5cf) will decrease coverage by 0.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   96.17%   95.34%   -0.83%     
==========================================
  Files          43       43              
  Lines        1437     1439       +2     
==========================================
- Hits         1382     1372      -10     
- Misses         55       67      +12     
Flag Coverage Δ
ios 95.34% <ø> (-0.83%) ⬇️
macspm 95.37% <ø> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...usCore/Source/EffectHandlers/EffectRouterDSL.swift 86.66% <0.00%> (-13.34%) ⬇️
MobiusCore/Source/EffectHandlers/EnumRoute.swift 75.00% <0.00%> (-8.34%) ⬇️
...rowableAssertion/Source/MobiusThrowableAssertion.m 91.66% <0.00%> (-8.34%) ⬇️
MobiusCore/Source/MobiusLogger.swift 78.26% <0.00%> (-4.35%) ⬇️
MobiusCore/Source/ConcurrentAccessDetector.swift 41.66% <0.00%> (-3.79%) ⬇️
...iusCore/Source/AsyncDispatchQueueConnectable.swift 93.75% <0.00%> (-3.13%) ⬇️
MobiusCore/Source/AsyncStartStopStateMachine.swift 91.30% <0.00%> (-2.90%) ⬇️
MobiusExtras/Source/ConnectableClass.swift 88.88% <0.00%> (-2.23%) ⬇️
MobiusCore/Source/MobiusController.swift 98.02% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01c5cf...7fdc12f. Read the comment docs.

Copy link
Contributor

@rastersize rastersize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kmcbride kmcbride merged commit 4a069ad into spotify:master Jan 2, 2022
@kmcbride kmcbride deleted the case-path-fix branch January 2, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants