Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace enum extraction with CasePath #181

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

kmcbride
Copy link
Collaborator

@kmcbride kmcbride commented Nov 1, 2021

Replaces enum extract via Mirror to instead use CasePaths, which should boost performance.

I cherry-picked the relevant pieces, consolidated them into a single file, and tweaked a few access levels to keep the types internal.

@kmcbride kmcbride requested a review from rastersize November 1, 2021 22:11
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #181 (db8c302) into master (142cf70) will increase coverage by 0.58%.
The diff coverage is 100.00%.

❗ Current head db8c302 differs from pull request most recent head fb357ca. Consider uploading reports for the commit fb357ca to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   95.55%   96.14%   +0.58%     
==========================================
  Files          43       42       -1     
  Lines        1462     1425      -37     
==========================================
- Hits         1397     1370      -27     
+ Misses         65       55      -10     
Flag Coverage Δ
ios ?
macspm 96.14% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
MobiusCore/Source/EffectHandlers/EnumRoute.swift 83.33% <100.00%> (+15.76%) ⬆️
...rowableAssertion/Source/MobiusThrowableAssertion.m

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142cf70...fb357ca. Read the comment docs.

@kmcbride kmcbride merged commit 8afb58c into spotify:master Nov 11, 2021
@kmcbride kmcbride deleted the case-path branch November 11, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants