Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 12.5 compatibility #175

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix Xcode 12.5 compatibility #175

merged 1 commit into from
Apr 28, 2021

Conversation

kmcbride
Copy link
Collaborator

Unfortunately can't yet upgrade the Actions config because macOS 11.0 pools are still in private preview.

@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #175 (88ca57a) into master (cbf289b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          43       43           
  Lines        1279     1279           
=======================================
  Hits         1207     1207           
  Misses         72       72           
Flag Coverage Δ
ios 94.37% <100.00%> (ø)
macspm 94.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
MobiusNimble/Source/NimbleFirstMatchers.swift 100.00% <100.00%> (ø)
MobiusNimble/Source/NimbleNextMatchers.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf289b...88ca57a. Read the comment docs.

Copy link
Contributor

@rastersize rastersize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

@akkismm31 akkismm31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

@caipre
Copy link
Contributor

caipre commented Apr 28, 2021

LGTM 👍🏻

@caipre caipre merged commit 9919fa8 into spotify:master Apr 28, 2021
@kmcbride kmcbride deleted the xcode-12.5 branch April 28, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants