Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XCFramework dependencies #174

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Conversation

kmcbride
Copy link
Collaborator

Updates dependencies to use XCFramework variants because bootstrapping the project currently fails with this error:

Building universal frameworks with common architectures is not possible. The device and simulator slices for "Nimble" both build for: arm64
Rebuild with --use-xcframeworks to create an xcframework bundle instead.

https://github.com/Carthage/Carthage#migrating-a-project-from-framework-bundles-to-xcframeworks

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #174 (cadc58c) into master (09eeb05) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   94.36%   94.37%           
=======================================
  Files          43       43           
  Lines        1278     1279    +1     
=======================================
+ Hits         1206     1207    +1     
  Misses         72       72           
Flag Coverage Δ
ios 94.37% <ø> (+<0.01%) ⬆️
macspm 94.31% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
MobiusCore/Source/MobiusHooks.swift 71.42% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09eeb05...4c08a16. Read the comment docs.

@kmcbride kmcbride force-pushed the dependency-xcframework branch 2 times, most recently from f8ea4df to e1a8eaf Compare February 19, 2021 20:08
@kmcbride kmcbride force-pushed the dependency-xcframework branch from e1a8eaf to 4c08a16 Compare February 19, 2021 20:13
@dflems dflems merged commit cbf289b into spotify:master Feb 19, 2021
@kmcbride kmcbride deleted the dependency-xcframework branch February 19, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants