Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle #file/#filePath distinction in Swift 5.3 #167

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

JensAyton
Copy link
Contributor

Addresses this warning in Xcode 12 beta:

.../MobiusNimble/Test/TestUtil.swift:38:90: warning: Parameter 'file' with default argument '#file' passed to parameter 'file', whose default argument is '#filePath'
.../MobiusNimble/Test/TestUtil.swift:38:90: warning: note: did you mean for parameter 'file' to default to '#filePath'?

@jeppes

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #167 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   94.09%   94.26%   +0.17%     
==========================================
  Files          41       45       +4     
  Lines        1219     1256      +37     
==========================================
+ Hits         1147     1184      +37     
  Misses         72       72              
Flag Coverage Δ
#ios 94.26% <ø> (+0.17%) ⬆️
#macspm 94.21% <ø> (+0.17%) ⬆️
Impacted Files Coverage Δ
...ource/Deprecated/BlockingFunctionConnectable.swift 100.00% <0.00%> (ø)
...biusCore/Source/Deprecated/ActionConnectable.swift 100.00% <0.00%> (ø)
...iusCore/Source/Deprecated/ClosureConnectable.swift 100.00% <0.00%> (ø)
...usCore/Source/Deprecated/ConsumerConnectable.swift 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1967cc...740351c. Read the comment docs.

@JensAyton JensAyton merged commit d466bbb into spotify:master Jun 24, 2020
@JensAyton JensAyton deleted the swift-5.3 branch June 24, 2020 10:12
@kmcbride kmcbride mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants