Connectable class is no longer abstract #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one has failing tests, not flakiness |
|
Otherwise good |
|
Right. 🤦 |
|
Xcode's error color really doesn't play well with my color blindness 🙃 |
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 94.39% 94.18% -0.21%
==========================================
Files 45 45
Lines 1249 1239 -10
==========================================
- Hits 1179 1167 -12
- Misses 70 72 +2
Continue to review full report at Codecov.
|
|
Fixed, @JensAyton |
JensAyton
approved these changes
Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make
ConnectableClassinto an abstract class has not worked out well in practice. Most subclasses simply just leaveonDisposeblank.@JensAyton