Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to .on(queue:) #157

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Add label to .on(queue:) #157

merged 1 commit into from
Apr 22, 2020

Conversation

jeppes
Copy link
Contributor

@jeppes jeppes commented Apr 22, 2020

  • Add label: .on(.main) --> on(queue: .main)
  • Add warning about using this function in raw loops.

@JensAyton

@jeppes jeppes changed the title .on(.main) --> on(queue: .main Add label to .on(queue:) Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          45       45           
  Lines        1249     1249           
=======================================
  Hits         1179     1179           
  Misses         70       70           
Flag Coverage Δ
#ios 94.39% <100.00%> (ø)
#macspm ?
Impacted Files Coverage Δ
...obiusCore/Source/EffectHandlers/EffectRouter.swift 98.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9bc24...3d8813e. Read the comment docs.

@jeppes jeppes merged commit 929287a into spotify:master Apr 22, 2020
@jeppes jeppes deleted the label-in-on-queue branch April 22, 2020 15:16
@kmcbride kmcbride mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants