Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. cleanup #154

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Misc. cleanup #154

merged 3 commits into from
Apr 21, 2020

Conversation

JensAyton
Copy link
Contributor

Odds and ends:

  • EventSource+Extensions.swift is now EventSourceMap.swift for consistency with ConnectableContramap/ConnectableMap
  • AnyConnectable is now a struct, since it has no reason not to be
  • Mobius enum is declared the normal way
  • Default error handler no longer prints call stack, default behaviour should be as vanilla as possible and clients can customize already
  • BeginnerLoop uses EffectRouter to avoid guiding people in the wrong direction

@jeppes

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #154 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   94.34%   94.47%   +0.12%     
==========================================
  Files          46       46              
  Lines        1291     1284       -7     
==========================================
- Hits         1218     1213       -5     
+ Misses         73       71       -2     
Flag Coverage Δ
#ios 94.47% <100.00%> (+0.12%) ⬆️
#macspm 94.41% <100.00%> (+0.12%) ⬆️
Impacted Files Coverage Δ
MobiusCore/Source/Mobius.swift 97.18% <ø> (ø)
MobiusCore/Source/MobiusHooks.swift 66.66% <ø> (+16.66%) ⬆️
MobiusExtras/Source/EventSourceMap.swift 100.00% <ø> (ø)
MobiusCore/Source/Connectable.swift 100.00% <100.00%> (ø)
MobiusExtras/Source/BeginnerLoop.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39dc39...42cbae6. Read the comment docs.

jeppes
jeppes previously approved these changes Apr 21, 2020
@JensAyton
Copy link
Contributor Author

Fixed a silly bug. I’m surprised that was possible!

@JensAyton JensAyton merged commit 44275ab into spotify:master Apr 21, 2020
@JensAyton JensAyton deleted the cleanup branch April 21, 2020 14:13
@kmcbride kmcbride mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants