Simplify MobiusLoop implementation #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 94.50% 94.39% -0.11%
==========================================
Files 46 45 -1
Lines 1291 1249 -42
==========================================
- Hits 1220 1179 -41
+ Misses 71 70 -1
Continue to review full report at Codecov.
|
jeppes
suggested changes
Apr 20, 2020
JensAyton
force-pushed
the
mobius-loop-rewrite
branch
from
8907f3c to
b61f4bc
Compare
|
The redness of the build is from a non-mandatory codecov -0.13% delta |
JensAyton
force-pushed
the
mobius-loop-rewrite
branch
from
df20f65 to
7bf37d7
Compare
jeppes
approved these changes
Apr 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complete rewrite of
MobiusLoop, withoutEventProcessor.After the threading rewrite,
EventProcessorwas just a wordy way to deal with initialization order and queue up effects received during setup. The latter can be handled by theWorkBag, and while the initialization dependencies are non-trivial, merging three layers of code into one makes things simpler.Behaviour change: effects passed to the initializer or posted in event source/effect handler subscription are now handled in randomized order. Previously they were queued up deterministically in
EventProcessor, which was an oversight.@jeppes @pettermahlen