Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Initiate completely from MobiusLoop #146

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

JensAyton
Copy link
Contributor

Initiation is a MobiusController concern.

Note behaviour change: MobiusLoop no longer triggers initiate logs.

@jeppes

Initiation is a MobiusController concern.

Note behaviour change: MobiusLoop no longer triggers initiate logs.
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #146 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   93.27%   93.20%   -0.08%     
==========================================
  Files          44       44              
  Lines        1309     1295      -14     
==========================================
- Hits         1221     1207      -14     
  Misses         88       88              
Flag Coverage Δ
#ios 93.20% <100.00%> (-0.08%) ⬇️
Impacted Files Coverage Δ
MobiusCore/Source/MobiusLogger.swift 82.60% <ø> (ø)
MobiusCore/Source/EventProcessor.swift 97.43% <100.00%> (ø)
MobiusCore/Source/Mobius.swift 90.14% <100.00%> (-2.17%) ⬇️
MobiusCore/Source/MobiusController.swift 98.67% <100.00%> (+0.06%) ⬆️
MobiusCore/Source/MobiusLoop.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe55d72...f3c7802. Read the comment docs.

@JensAyton JensAyton merged commit c630cf1 into spotify:master Apr 8, 2020
@JensAyton JensAyton deleted the simplify-initiate branch April 8, 2020 10:54
@kmcbride kmcbride mentioned this pull request Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants