Make private Cartfile public in order to fix installation via Carthage #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you just need |
|
Either way I don't think it'll hurt! |
dflems
previously approved these changes
Mar 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=======================================
Coverage 96.83% 96.83%
=======================================
Files 35 35
Lines 789 789
=======================================
Hits 764 764
Misses 25 25Continue to review full report at Codecov.
|
|
@dflems You're right, only moved |
dflems
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like that specifying
QuickandNimblein the public Cartfile is the only way to make Carthage happy when buildingMobiusNimble. Since Carthage doesn't support subspecs, client will need to pull down test dependencies even though they may not be interested in using them together withMobiusNimble. They can obviously always choose to integrate the frameworks into their project or not.This is what has been suggested by other OSS projects too such as Moya.