Install spotbugs packages before testing gradle plugin #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin refer discussion at: spotbugs@f7a08d9
KengoTODA
referenced
this pull request
Sep 8, 2017
* add test to find problem like #320 * close #320: iterate ClassesDirs to find all target files * install not only spotbugs but also others * move timing to install * use both of central and local as repository * update CHANGELOG * Revert "move timing to install" This reverts commit e997efb. * refs #337: extract shared logic to Before method * refs #337: add more tests * shorten test by deleting temporal File object in field * generate plugin classpath by gradle this change lets us stop invoking `install` task before the `test`. * Revert "generate plugin classpath by gradle" This reverts commit 9952aa6.
ThrawnCA
approved these changes
Sep 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer discussion at: f7a08d9
I confirmed that
./gradlew buildcan pass even afterrm -rf ~/.m2/repository/com/github/spotbugsin local.