Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New performance rule for using String replace instead of replaceAll #705

Open
blindspeed90 opened this issue Jul 20, 2018 · 1 comment
Open

New performance rule for using String replace instead of replaceAll #705

blindspeed90 opened this issue Jul 20, 2018 · 1 comment

Comments

@blindspeed90
Copy link

People mistakenly use replaceAll as a literal replacement, and will get the overhead of doing a regexp. Possibly the code could check the parameter for the existence of any special regexp characters as its' test.
@lasselindqvist
Copy link
Contributor

Based on https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html it would make sense to warn if the replaceAll does not contain any letter from "\.[]{}()<>*+-=?^$|"

lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 8, 2018
@lasselindqvist
Implement issue spotbugs#705
be89d58 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 9, 2018
@lasselindqvist
Implement issue spotbugs#705
fa2ecd5 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 9, 2018
@lasselindqvist
Implement issue spotbugs#705
4c9f16c 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 9, 2018
@lasselindqvist
Implement issue spotbugs#705
4d0d53e 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 10, 2018
@lasselindqvist
Implement issue spotbugs#705
83f8562 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 10, 2018
@lasselindqvist
Implement issue spotbugs#705
8ff3709 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 10, 2018
@lasselindqvist
Implement issue spotbugs#705
1ff36f9 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 14, 2018
@lasselindqvist
Implement issue spotbugs#705
d75e9c5 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 15, 2018
@lasselindqvist
Implement issue spotbugs#705
681f80c 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 19, 2018
@lasselindqvist
Implement issue spotbugs#705
a3f3e96 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 21, 2018
@lasselindqvist
Implement issue spotbugs#705
7e585b7 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 23, 2018
@lasselindqvist
Implement issue spotbugs#705
73bfae9 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
lasselindqvist added a commit to lasselindqvist/spotbugs that referenced this issue Nov 23, 2018
@lasselindqvist
Implement issue spotbugs#705
294fd65 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
KengoTODA pushed a commit that referenced this issue Nov 27, 2018
@lasselindqvist @KengoTODA
Implement issue #705
eec0f0f 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
RahulNagekar pushed a commit to RahulNagekar/spotbugs that referenced this issue Dec 3, 2018
@lasselindqvist @RahulNagekar
Implement issue spotbugs#705
d5887ea 
Implement new detector IRA_INEFFICIENT_REPLACEALL. Finds occurrences of replaceAll(String regex, String replacement) without any special regex characters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lasselindqvist @blindspeed90