Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outputDirectory not work at running spotbugs:spotbugs goal #807

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix outputDirectory not work at running spotbugs:spotbugs goal #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f449bf1
fix outputDirectory not work at running spotbugs:spotbugs goal
exiahuang May 26, 2024
9234e2a
Merge branch 'master' into fix-report-outputdirectory
hazendaz Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/it/html-report/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
<configuration>
<xmlOutput>true</xmlOutput>
<htmlOutput>true</htmlOutput>
<outputDirectory>target/test-output-directory</outputDirectory>
<failOnError>false</failOnError>
<debug>@spotbugsTestDebug@</debug>
<threshold>High</threshold>
Expand Down
2 changes: 1 addition & 1 deletion src/it/html-report/verify.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
File spotbugsHtml = new File(basedir, 'target/spotbugs.html')
File spotbugsHtml = new File(basedir, 'target/test-output-directory/spotbugs.html')
assert spotbugsHtml.exists()
2 changes: 1 addition & 1 deletion src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,7 +1098,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait {

log.debug("****** SpotBugsMojo executeSpotbugs *******")

File htmlTempFile = new File("${project.build.directory}/spotbugs.html")
File htmlTempFile = new File("${outputDirectory}/spotbugs.html")
if (htmlOutput) {
forceFileCreation(htmlTempFile)
}
Expand Down