Added separate goals for check and verify (fixes #114) #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crizzis
commented
Feb 15, 2022
| * | ||
| * @since 4.5 | ||
| */ | ||
| @Mojo( name = "verify", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST, requiresProject = true, threadSafe = true) |
There was a problem hiding this comment.
Not sure about the naming, though, might be confusing to some
There was a problem hiding this comment.
@crizzis I'm ok with changes overall but need a couple things that I think will help. First, bump since to 4.7 and we will target 4.7. Second, can you use more description from original #114 to highlight why this exists. That I think will help others to understand as looking simply at the source was confusing to me as the purpose. After reading the original issue and looking at the integration tests did I put it together so I think that will be usefule here to help put that together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.