Skip to content

Commit

Permalink
Merge pull request #940 from hazendaz/master
Browse files Browse the repository at this point in the history
Clarify maven version requirements in readme and cleanup antrun output
  • Loading branch information
hazendaz authored Nov 29, 2024
2 parents fc33190 + e8c96fc commit 783177c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Building spotbugs-maven-plugin Requirements
===========================================

Java 17+ is required to build the project. Java 8+ is required for spotbugs analysis.
Maven 3.9.9 is required to build the project. It can be used as low as maven 3.6.3 in usage.

spotbugs-maven-plugin
=====================
Expand Down Expand Up @@ -61,7 +62,7 @@ mvn -Dmaven.surefire.debug="-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspe

Run gui with a specific version
```
mvn com.github.spotbugs:spotbugs-maven-plugin:4.8.6.2:gui
mvn com.github.spotbugs:spotbugs-maven-plugin:4.8.6.6:gui
```

## Creating new site examples ##
Expand Down
12 changes: 5 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@
<plexusUtilsVersion>4.0.2</plexusUtilsVersion>
<plexusXmlVersion>3.0.1</plexusXmlVersion>

<antrunPluginVersion>3.1.0</antrunPluginVersion>
<l10nPluginVersion>1.1.0</l10nPluginVersion>
<codenarcPluginVersion>0.22-1</codenarcPluginVersion>
<gmavenPluginVersion>4.0.1</gmavenPluginVersion>
Expand Down Expand Up @@ -993,7 +992,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
<version>${antrunPluginVersion}</version>
<executions>
<execution>
<id>prepare-integration-test-local-spotbugs-src</id>
Expand All @@ -1003,12 +1001,12 @@
<phase>pre-integration-test</phase>
<configuration>
<target>
<echo>Copying Source for Tests......</echo>
<echo>Making ${integrationTestSrc}</echo>
<echo level="debug">Copying Source for Tests......</echo>
<echo level="debug">Making ${integrationTestSrc}</echo>
<mkdir dir="${integrationTestSrc}" />
<echo>Copying to ${integrationTestSrc}</echo>
<echo>from ${localTestSrc}</echo>
<echo>for ${includesTestSrcPattern}</echo>
<echo level="debug">Copying to ${integrationTestSrc}</echo>
<echo level="debug">from ${localTestSrc}</echo>
<echo level="debug">for ${includesTestSrcPattern}</echo>
<copy todir="${integrationTestSrc}">
<fileset dir="${localTestSrc}" includes="${includesTestSrcPattern}" />
</copy>
Expand Down

0 comments on commit 783177c

Please sign in to comment.