-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge from staging repo to release v4.0.0 #191
Conversation
Use JDK11 to build the project
SpotBugsTask class should not be abstract, to let users instantiate it by `task(type: ...SpotBugsTask)`.
Gradle plugin should ignore other files such as .xml, .txt, .properties and so on. Only .class files should be considered as the target to analyse by default. fix #89
BREAKING CHANGE: all the implementations are written from scratch Emacs support, `sourceSets` property, and some features are dropped intentionally.
Travis is failing, but we can ignore it because we do not use Travis from this version. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
@spotbugs/everyone please review this PR. This PR contains many changes, but important points are limited: e2bdae0 remove all existing files Note that this PR is not able to be merged by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a task to add more documentation to the classes. In general they are readable, but just to make it easier for those who aren't as familiar with the "new" java 8 lambda expressions and what each class should be doing.
Looks great to me, thanks for all the hard work!
Replace all things forked from old FindBugs gradle plugin with newly created one from scratch.
Now both of copyright holder and license holder are SpotBugs team.
It also depends on no internal package from Gradle, so we hope that broken backward compatibility won't be introduced so frequently.
After we merge this PR, we need to handle following operations:
TO contributors: I cannot find who enables GitHub Sponsors. When you enabled it, please consider to submit PR to update
.github/FUNDING.yml
to list your account.close #178
close #180