Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade SpotBugs to 4.8.1 #853

Merged
merged 1 commit into from
Nov 14, 2023
Merged

deps: upgrade SpotBugs to 4.8.1 #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
uses: ./.github/actions/sonar-update-center
with:
prop-file: findbugs.properties
description: Use SpotBugs 4.7.3, sb-contrib 7.6.0, and findsecbugs 1.12.0
description: Use SpotBugs 4.8.1, sb-contrib 7.6.0, and findsecbugs 1.12.0
minimal-supported-sq-version: 8.9
latest-supported-sq-version: LATEST
changelog-url: https://github.com/spotbugs/sonar-findbugs/releases/tag/${{ github.event.release.tag_name }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@ Findbugs Plugin version|Embedded SpotBugs/Findbugs version|Embedded Findsecbugs
4.2.2 | 4.7.3 (SpotBugs) | 1.12.0 | 7.4.7 (sb-contrib) | 1.8|7.9~|5.10.1.16922
4.2.3 | 4.7.3 (SpotBugs) | 1.12.0 | 7.4.7 (sb-contrib) | 1.8|7.9~|5.10.1.16922
4.2.4 | 4.7.3 (SpotBugs) | 1.12.0 | 7.6.0 (sb-contrib) | 1.8|7.9~|5.10.1.16922
4.2.5-SNAPSHOT | 4.7.3 (SpotBugs) | 1.12.0 | 7.6.0 (sb-contrib) | 1.8|7.9~|5.10.1.16922
4.2.5-SNAPSHOT | 4.8.1 (SpotBugs) | 1.12.0 | 7.6.0 (sb-contrib) | 1.8|7.9~|5.10.1.16922
4 changes: 2 additions & 2 deletions generate_profiles/BuildXmlFiles.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ import groovy.json.JsonSlurper;

@Grapes([

@Grab(group='com.github.spotbugs', module='spotbugs', version='4.7.3'),
@Grab(group='com.github.spotbugs', module='spotbugs', version='4.8.1'),
@Grab(group='com.mebigfatguy.sb-contrib', module='sb-contrib', version='7.6.0'),
@Grab(group='com.h3xstream.findsecbugs' , module='findsecbugs-plugin', version='1.12.0')]
)


FB = new Plugin(groupId: 'com.github.spotbugs', artifactId: 'spotbugs', version: '4.7.3')
FB = new Plugin(groupId: 'com.github.spotbugs', artifactId: 'spotbugs', version: '4.8.1')
CONTRIB = new Plugin(groupId: 'com.mebigfatguy.sb-contrib', artifactId: 'sb-contrib', version: '7.6.0')
FSB = new Plugin(groupId: 'com.h3xstream.findsecbugs', artifactId: 'findsecbugs-plugin', version: '1.12.0')

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/sonar/plugins/findbugs/rules/FindbugsRulesDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ public final class FindbugsRulesDefinition implements RulesDefinition {

public static final String REPOSITORY_KEY = "findbugs";
public static final String REPOSITORY_NAME = "FindBugs";
public static final int RULE_COUNT = 461;
public static final int DEACTIVED_RULE_COUNT = 6;
public static final int RULE_COUNT = 475;
public static final int DEACTIVED_RULE_COUNT = 7;

@Override
public void define(Context context) {
Expand Down
42 changes: 42 additions & 0 deletions src/main/resources/org/sonar/plugins/findbugs/profile-findbugs-and-fb-contrib.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<FindBugsFilter><!-- This file is auto-generated. -->
<Match>
<Bug pattern='CT_CONSTRUCTOR_THROW' />
</Match>
<Match>
<Bug pattern='JUA_DONT_ASSERT_INSTANCEOF_IN_TESTS' />
</Match>
Expand Down Expand Up @@ -431,6 +434,9 @@
<Match>
<Bug pattern='DL_SYNCHRONIZATION_ON_SHARED_CONSTANT' />
</Match>
<Match>
<Bug pattern='DL_SYNCHRONIZATION_ON_INTERNED_STRING' />
</Match>
<Match>
<Bug pattern='DL_SYNCHRONIZATION_ON_BOOLEAN' />
</Match>
Expand Down Expand Up @@ -557,6 +563,9 @@
<Match>
<Bug pattern='SE_TRANSIENT_FIELD_NOT_RESTORED' />
</Match>
<Match>
<Bug pattern='SE_PREVENT_EXT_OBJ_OVERWRITE' />
</Match>
<Match>
<Bug pattern='SE_METHOD_MUST_BE_PRIVATE' />
</Match>
Expand Down Expand Up @@ -1382,6 +1391,39 @@
<Match>
<Bug pattern='USC_POTENTIAL_SECURITY_CHECK_BASED_ON_UNTRUSTED_SOURCE' />
</Match>
<Match>
<Bug pattern='ASE_ASSERTION_WITH_SIDE_EFFECT' />
</Match>
<Match>
<Bug pattern='ASE_ASSERTION_WITH_SIDE_EFFECT_METHOD' />
</Match>
<Match>
<Bug pattern='PA_PUBLIC_PRIMITIVE_ATTRIBUTE' />
</Match>
<Match>
<Bug pattern='PA_PUBLIC_ARRAY_ATTRIBUTE' />
</Match>
<Match>
<Bug pattern='PA_PUBLIC_MUTABLE_OBJECT_ATTRIBUTE' />
</Match>
<Match>
<Bug pattern='VSC_VULNERABLE_SECURITY_CHECK_METHODS' />
</Match>
<Match>
<Bug pattern='AA_ASSERTION_OF_ARGUMENTS' />
</Match>
<Match>
<Bug pattern='PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES' />
</Match>
<Match>
<Bug pattern='PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_FIELD_NAMES' />
</Match>
<Match>
<Bug pattern='PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_METHOD_NAMES' />
</Match>
<Match>
<Bug pattern='PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_LOCAL_VARIABLE_NAMES' />
</Match>
<Match>
<Bug pattern='ISB_INEFFICIENT_STRING_BUFFERING' />
</Match>
Expand Down
42 changes: 42 additions & 0 deletions src/main/resources/org/sonar/plugins/findbugs/profile-findbugs-only.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<FindBugsFilter><!-- This file is auto-generated. -->
<Match>
<Bug pattern='CT_CONSTRUCTOR_THROW' />
</Match>
<Match>
<Bug pattern='JUA_DONT_ASSERT_INSTANCEOF_IN_TESTS' />
</Match>
Expand Down Expand Up @@ -431,6 +434,9 @@
<Match>
<Bug pattern='DL_SYNCHRONIZATION_ON_SHARED_CONSTANT' />
</Match>
<Match>
<Bug pattern='DL_SYNCHRONIZATION_ON_INTERNED_STRING' />
</Match>
<Match>
<Bug pattern='DL_SYNCHRONIZATION_ON_BOOLEAN' />
</Match>
Expand Down Expand Up @@ -557,6 +563,9 @@
<Match>
<Bug pattern='SE_TRANSIENT_FIELD_NOT_RESTORED' />
</Match>
<Match>
<Bug pattern='SE_PREVENT_EXT_OBJ_OVERWRITE' />
</Match>
<Match>
<Bug pattern='SE_METHOD_MUST_BE_PRIVATE' />
</Match>
Expand Down Expand Up @@ -1382,4 +1391,37 @@
<Match>
<Bug pattern='USC_POTENTIAL_SECURITY_CHECK_BASED_ON_UNTRUSTED_SOURCE' />
</Match>
<Match>
<Bug pattern='ASE_ASSERTION_WITH_SIDE_EFFECT' />
</Match>
<Match>
<Bug pattern='ASE_ASSERTION_WITH_SIDE_EFFECT_METHOD' />
</Match>
<Match>
<Bug pattern='PA_PUBLIC_PRIMITIVE_ATTRIBUTE' />
</Match>
<Match>
<Bug pattern='PA_PUBLIC_ARRAY_ATTRIBUTE' />
</Match>
<Match>
<Bug pattern='PA_PUBLIC_MUTABLE_OBJECT_ATTRIBUTE' />
</Match>
<Match>
<Bug pattern='VSC_VULNERABLE_SECURITY_CHECK_METHODS' />
</Match>
<Match>
<Bug pattern='AA_ASSERTION_OF_ARGUMENTS' />
</Match>
<Match>
<Bug pattern='PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES' />
</Match>
<Match>
<Bug pattern='PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_FIELD_NAMES' />
</Match>
<Match>
<Bug pattern='PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_METHOD_NAMES' />
</Match>
<Match>
<Bug pattern='PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_LOCAL_VARIABLE_NAMES' />
</Match>
</FindBugsFilter>
Loading