Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download lyrics with save operation #2206

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Download lyrics with save operation #2206

merged 1 commit into from
Oct 12, 2024

Conversation

SilentDude
Copy link
Contributor

Download lyrics with save operation

Description

Save operation in version 4.2.8 doesn't download lyrics from lyrics providers. I copied this feature from downloader.py -> search_and_download() and refactored save operation code a bit.

Related Issue

#2151

Motivation and Context

Allows for downloading song lyrics, without need to download entire track.

How Has This Been Tested?

Ran save operation on version 4.2.8 and my commit, then compared save-file outputs.
Also compared download operation using --save-file argument to be sure.
Checked cases both with and without --preload argument.
I only notice change in availability of lyrics in save-file after save operation.

Environment:
Python 3.12.6
Venv

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project --- ran pylint, black and mypy
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document --- is it renamed to CODE_OF_CONDUCT.md?
  • I have added tests to cover my changes
  • All new and existing tests passed - 1 failed, although it also fails on main branch

@xnetcat xnetcat merged commit 15ab489 into spotDL:dev Oct 12, 2024
@xnetcat xnetcat mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants