Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download individual album art for each track when using --playlist-numbering #2204

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

PranjalSurana
Copy link
Contributor

Title

Download individual album art for each track when using --playlist-numbering

Description

A new CLI argument to retain the original album art of track while downloading playlist

Related Issue

#2193

Motivation and Context

Gives the user to keep original track art while downloading playlist

How Has This Been Tested?

Ran spotDL many times, to test various scenarios

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

xnetcat and others added 2 commits September 6, 2024 12:21
Bug fixes:
- Always include filter when sending requests to piped by @xnetcat 
- Check status code when getting response from piped by @xnetcat 
- Use piped.video instead of main piped instance by @j3bx in spotDL#2172
- Fixed `RuntimeError: Directory 'C:\Users\myuser\.spotdl\web-ui\dist' does not exist` by @R0GUE-A5H in spotDL#2173
- Make sync command aware of file name changes by @xnetcat 

Documentation:
- Chore: update downloader.py by @Elto

Co-authored-by: kuba <[email protected]>
Co-authored-by: Alan <[email protected]>
Co-authored-by: Ikko Eltociear Ashimine <[email protected]>
Co-authored-by: Ash <[email protected]>
@xnetcat xnetcat changed the base branch from master to dev October 12, 2024 17:37
@xnetcat xnetcat merged commit 52fb79a into spotDL:dev Oct 12, 2024
@Silverarmor
Copy link
Member

Hi @PranjalSurana

Great to see you around the spotDL project. We are always on the lookout for more volunteers to contribute to spotDL.
Would you be interested in joining the spotDL development team?

Thanks for your contributions thus far.
You can also join the spotDL discord @ https://discord.gg/xCa23pwJWY

@PranjalSurana
Copy link
Contributor Author

Hi @Silverarmor
I am interested to join the spotDL development team!!

@Silverarmor
Copy link
Member

Thanks @PranjalSurana .
I've added you to the GitHub organisation. You should receive an email or you can accept it at https://github.com/spotDL within 7 days.

Please join the spotDL Discord and mention me (@Silverarmor) so I can link your discord to your GH account. From that - simply discuss in the dev channels, or work on PRs/issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants