Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for multiple keywords in --ignore-albums option #2014

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

bharat-nair
Copy link
Contributor

Title

Fix for multiple keywords in --ignore-albums

Description

Modified condition to check all keywords together.

Related Issue

#2009

How Has This Been Tested?

spotdl https://open.spotify.com/artist/5ftlDLqup1wvAk1VTPIC6R --ignore-albums "varra" "pep" "roc" "hide" --output '{artist}/({year}) {album}/{artist} - {album} - {track-number} - {title}'

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@egndz
Copy link
Contributor

egndz commented Feb 13, 2024

@bharat-nair can you have a look at tests or should I ?

@egndz
Copy link
Contributor

egndz commented Feb 19, 2024

Based on the tests results, this appears in the query results: https://www.youtube.com/watch?v=1G8QzEGslJI
this has 35 views that shouldn't appear at all.

How we can test it @xnetcat ? Should this be related to scoring mechanism?

@Silverarmor Silverarmor changed the base branch from master to dev February 22, 2024 03:29
@xnetcat xnetcat merged commit 17b1eb0 into spotDL:dev Feb 23, 2024
0 of 10 checks passed
@xnetcat xnetcat mentioned this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants